fix: format BigQuery numeric output as decimal strings
This change updates both bigquery-sql and bigquery-execute-sql tools to format NUMERIC and BIGNUMERIC values as decimal strings (e.g., "9.5") instead of rational fractions (e.g., "19/2"). This ensures the tools' output matches the BigQuery REST API JSON format.
Key changes:
- Added
NormalizeValuefunction ininternal/tools/bigquery/bigquerycommonto handle*big.Ratconversion with 38-digit precision and trailing zero trimming. - Updated
bigquery-sqlandbigquery-execute-sqlto useNormalizeValue. - Added comprehensive tests in
internal/tools/bigquery/bigquerycommon/conversion_test.go.
Description
Should include a concise description of the changes (bug or feature), it's impact, along with a summary of the solution
PR Checklist
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure you reviewed CONTRIBUTING.md
- [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add
!if this involve a breaking change
🛠️ Fixes #<issue_number_goes_here>
Summary of Changes
Hello @shobsi, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an inconsistency in how BigQuery numeric types (NUMERIC and BIGNUMERIC) are represented in the output of the bigquery-sql and bigquery-execute-sql tools. By converting these values from rational fractions to decimal strings, the tools' output now accurately matches the expected JSON format of the BigQuery REST API, improving data consistency and interoperability.
Highlights
- BigQuery Numeric Output Formatting: NUMERIC and BIGNUMERIC values from BigQuery tools (bigquery-sql and bigquery-execute-sql) are now formatted as decimal strings (e.g., "9.5") instead of rational fractions (e.g., "19/2"). This ensures the output matches the BigQuery REST API JSON format.
- New
NormalizeValueFunction: A new utility function,NormalizeValue, has been introduced ininternal/tools/bigquery/bigquerycommonto handle the conversion of*big.Rattypes to decimal strings with 38-digit precision and trailing zero trimming. It also recursively processes nested slices and maps. - Tool Integration: Both
bigquery-sqlandbigquery-execute-sqltools have been updated to utilize the newNormalizeValuefunction to ensure consistent output formatting for numeric values. - Comprehensive Testing: Extensive unit tests have been added for the
NormalizeValuefunction ininternal/tools/bigquery/bigquerycommon/conversion_test.goto cover various data types and nested structures, ensuring its correctness.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.