genai-toolbox icon indicating copy to clipboard operation
genai-toolbox copied to clipboard

chore(tools/sqlite,tools/tidb,tools/trino,tools/utility,tools/valkey,tools/yugabytedbsql): decouple source config from tools

Open Yuan325 opened this issue 3 months ago • 1 comments

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

Yuan325 avatar Nov 27 '25 17:11 Yuan325

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant architectural change by decoupling the configuration and management of data sources from the tools that utilize them. Previously, tools held direct references to database connections or clients. Now, these connections are dynamically retrieved from a central ResourceManager (via tools.SourceProvider) when a tool's Invoke() or RequiresClientAuthorization() method is called. This enhances modularity, reduces tight coupling between tools and specific source implementations, and streamlines source management.

Highlights

  • Decoupled Source Configuration: Tools no longer store direct references to database connections or clients (e.g., *sql.DB, valkey.Client) within their structs, promoting a more stateless design.
  • Dynamic Source Retrieval: Tools now dynamically fetch the required source connection at runtime via the tools.SourceProvider interface during Invoke() and RequiresClientAuthorization() calls, rather than holding them as part of their initial configuration.
  • Reduced Coupling: Direct imports of specific source implementations (e.g., internal/sources/sqlite) have been removed from tool packages, improving modularity and reducing tight coupling.
  • Updated Authorization Signature: The RequiresClientAuthorization method's return type has been updated across affected tools from bool to (bool, error) to allow for error propagation.
  • Test Refactoring: Corresponding test files have been updated to remove direct database setup and invocation tests, aligning with the new dynamic source retrieval pattern.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 27 '25 17:11 gemini-code-assist[bot]