chore(tools/oracle,tools/postgres,tools/redis,tools/singlestore,tools/spanner): decouple source config from tools
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.
Summary of Changes
Hello @Yuan325, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant architectural refactoring across various database and client tools (Oracle, Postgres, Redis, SingleStore, Spanner). The core change involves decoupling the direct management of data source connections from the tools themselves. Instead of holding direct references to database pools or clients, tools now dynamically obtain these resources from a centralized ResourceManager when they need to perform an operation. This change promotes a more flexible and maintainable design by centralizing resource management and reducing tight coupling.
Highlights
-
Decoupled Source Configuration: The direct dependency of tools on specific database or client source configurations has been removed. Tools now dynamically retrieve their required source (e.g., OracleDB, PostgresPool, RedisClient, SingleStorePool, SpannerClient) from a
ResourceManagerduring theirInvokemethod execution. -
Improved Modularity and Testability: By fetching sources at runtime via an interface (
tools.SourceProvider), the tools are no longer tightly coupled to concrete source implementations. This enhances modularity, simplifies testing, and allows for more flexible configuration of data sources. -
Streamlined Tool Initialization: The
Initializemethods for all affected tools (Oracle, Postgres, Redis, SingleStore, Spanner) have been simplified. They no longer perform direct source validation or store direct references to database connection pools/clients, deferring these operations to theInvokemethod. -
Updated
RequiresClientAuthorizationSignature: TheRequiresClientAuthorizationmethod across all modified tools now returns a(bool, error)tuple, aligning with a more robust error handling pattern.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/gemini review