genai-toolbox icon indicating copy to clipboard operation
genai-toolbox copied to clipboard

chore(tools/mssql,tools/mysql,tools/neo4j,tools/oceanbase): decouple source config from tools

Open Yuan325 opened this issue 3 months ago • 1 comments

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

Yuan325 avatar Nov 27 '25 17:11 Yuan325

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural improvement by decoupling the database source configuration from the individual tools that utilize them. Instead of tools maintaining direct references to specific database connection pools, they now dynamically fetch the required source information from a central ResourceManager at runtime. This change enhances modularity, reduces tight coupling between tools and specific source implementations, and simplifies the overall structure of the tool definitions.

Highlights

  • Decoupled Source Configuration: Tools no longer directly import or store specific database source types (e.g., mssql, mysql, neo4j, oceanbase).
  • Dynamic Source Retrieval: Database connection details are now retrieved dynamically from a ResourceManager (or SourceProvider) during the Invoke and Initialize phases of a tool's lifecycle.
  • Simplified Tool Structs: The Tool structs across various database integrations have been streamlined by removing direct fields for database connection pools (e.g., *sql.DB, neo4j.DriverWithContext).
  • Updated Authorization Interface: The RequiresClientAuthorization method signature has been updated to return an error alongside the boolean, allowing for more robust error handling.
  • Removed Static Compatibility Checks: Static compatibleSources arrays and their associated checks during tool initialization have been removed, as compatibility is now verified dynamically when the source is retrieved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 27 '25 17:11 gemini-code-assist[bot]

/gemini review

Yuan325 avatar Dec 11 '25 18:12 Yuan325