gcp-metadata icon indicating copy to clipboard operation
gcp-metadata copied to clipboard

refactor: `fastFailMetadataRequest` to use `Promise.any`

Open danielbankhead opened this issue 1 year ago • 2 comments

We can streamline fastFailMetadataRequest by using Promise.any in Node 15+ rather than Promise.race:

https://github.com/googleapis/gcp-metadata/blob/92f258ca6a62160ed9b9bdedf15a2ae147f4f35c/src/index.ts#L179-L229

danielbankhead avatar Nov 10 '23 18:11 danielbankhead

Hi @danielbankhead I would like to work on this

Dhoni77 avatar Nov 11 '23 01:11 Dhoni77

Thanks @Dhoni77; note that this will require us to Node 16 (next stable), which will not happen for some time.

danielbankhead avatar Nov 13 '23 19:11 danielbankhead