gaxios icon indicating copy to clipboard operation
gaxios copied to clipboard

bug: update GaxiosError code to include a string or a number

Open sofisl opened this issue 3 years ago • 2 comments

We need to allow either string or number representation for GaxiosError code.

See this PR describing the problem: https://github.com/googleapis/google-auth-library-nodejs/pull/1165

This is the original bug: https://github.com/googleapis/google-auth-library-nodejs/issues/1092

This will be a breaking change, so we need to wait until the next major version to make this change.

sofisl avatar May 05 '21 01:05 sofisl

Making p3, since our intention is to drop Node 10 in 6 months.

bcoe avatar May 05 '21 18:05 bcoe

Relabeling as a FR since it's not breaking anyone's functionality currently, but will be a bug we correct in the next version.

sofisl avatar Nov 02 '21 17:11 sofisl

Fixed in https://github.com/googleapis/gaxios/pull/552

danielbankhead avatar Aug 11 '23 06:08 danielbankhead