gax-nodejs icon indicating copy to clipboard operation
gax-nodejs copied to clipboard

fix: Use a hashed id for default root name

Open orgads opened this issue 1 year ago • 1 comments

When multiple packages are imported, and all of them were generated in a way that uses default as the root name, each imported package overwrites the definitions of the previous ones.

Solve by assigning a hashed (fallback) name to each generated package.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea

  • [X] Ensure the tests and linter pass

  • [X] Code coverage does not decrease (if any source code was changed)

  • [X] Appropriate docs were updated (if necessary)

  • Relates to #1529 🦕

orgads avatar Mar 27 '24 17:03 orgads

@sofisl

orgads avatar Mar 28 '24 08:03 orgads

/gcbrun

sofisl avatar Jun 26 '24 20:06 sofisl