gax-java icon indicating copy to clipboard operation
gax-java copied to clipboard

Consider moving ProtobufMessageFeature native image configuration to gax

Open mpeddada1 opened this issue 3 years ago • 1 comments

Currently java-compute brings in gax-grpc for the purpose of bringing in ProtobufMessageFeature. The ProtobufMessageFeature class is used to register reflection configurations for all the sub-classes of com.google.protobuf.GeneratedMessageV3 which is used by generated client libraries.

However, adding a dependency on gax-grpc can cause confusion especially when a library (such a java-compute) is REST-based and has also resulted in some unintended behavior (https://github.com/googleapis/java-compute/pull/721) during native image compilation.

TODO: The dependency on gax-grpc needs to be removed from java-compute once this change is made, released and gax is upgraded in the libraries

cc: @blakeli0 @suztomo

mpeddada1 avatar Sep 09 '22 16:09 mpeddada1

https://github.com/googleapis/gax-java/issues/1788#issue-1368087289

Mk1206mk avatar Oct 01 '22 01:10 Mk1206mk