gapic-generator-python

gapic-generator-python copied to clipboard

A file `logging.py` exists in the generated client for `google-cloud-logging` in the directory `google/cloud/logging_v2/types` [here](https://github.com/googleapis/gapic-generator-python/blob/main/tests/integration/goldens/logging/google/cloud/logging_v2/types/logging.py). It's not ideal to import the client using the statement `from google.cloud.logging_v2.types import logging` like...

parthea

Python 3.7 and 3.8 are marked as 'end of life' in https://devguide.python.org/versions/#python-release-cycle. They should be removed from the default branch once https://github.com/googleapis/google-cloud-python/issues/11437 is fixed. Googlers see internal issue b/340584761

parthea

In https://github.com/googleapis/googleapis/commit/b7003aa7b696e5b3dac14326bb05d088640e0cdb, the deprecated [option](https://developers.google.com/protocol-buffers/docs/proto#options) was added to the `DB_CLOUD_SQL_POSTGRES` field of `DatabaseType` in google/cloud/contentwarehouse/v1/common.proto, however the generated client in https://github.com/googleapis/google-cloud-python/pull/11565/files did not contain the deprecation message. We should add...

parthea

Add index file for autogenerated samples

2

See request in https://github.com/googleapis/python-memcache/issues/234 to add an index file in the directory where we have autogenerated samples. It's very difficult to find specific samples due to the long files names.

parthea

Github Actions CI is timing out

5

See example of failure here: https://github.com/googleapis/gapic-generator-python/actions/runs/4103356306/jobs/7077442094 The command which is failing is `sudo apt-get update` here https://github.com/googleapis/gapic-generator-python/blob/b4d1c4b2a26bc27ce5c1f7316c52636871d48418/.github/workflows/tests.yaml#L60-L62

parthea

Similar to https://github.com/googleapis/gapic-generator-python/issues/2357, we should add a presubmit to test `grpcio` and `grpcio-status` at HEAD (from source) to get early feedback

parthea

Similar to https://github.com/googleapis/proto-plus-python/issues/426, we should add a presubmit to test protobuf at HEAD (from source) to get early feedback

parthea

`ValueError: metadata was invalid` occurs when key in request metadata contains uppercase charactors

2

See the following test which fails when an uppercase is used in the metadata key https://github.com/googleapis/gapic-generator-python/blob/c72411d4507a4bea08233a527120fe66fec9ae80/tests/system/test_request_metadata.py#L20-L28 ``` def test_metadata_string(echo): echo.echo( showcase.EchoRequest( content="The hail in Wales falls mainly on the snails.",...

parthea

Reduce code duplication in method signatures throughout the code base

1

See the diff in PR https://github.com/googleapis/gapic-generator-python/pull/2253/files which shows changes to the following code which appears throughout the code base ``` retry: OptionalRetry = gapic_v1.method.DEFAULT, timeout: Union[float, object] = gapic_v1.method.DEFAULT, metadata:...

parthea

Remove option `add-iam-methods`

1

The `add-iam-methods` option and corresponding nox session `showcase_unit_add_iam_methods` should be removed from the codebase as it is redundant code. https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/gapic/utils/options.py#L57 https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L627 https://github.com/googleapis/gapic-generator-python/blob/515dc8ac17b9a8177feaa84416ab88e671c5359c/noxfile.py#L513 Before it can be removed, we need to...

parthea