gapic-generator-python

gapic-generator-python copied to clipboard

Improve support for `X-Goog-FieldMask` header

2

#### Environment details - OS type and version: MacOS 14.5 (23F79) - Python version: 3.12.3 - pip version: 24.0 - `google-api-core` version: 2.19.1 #### Steps to reproduce 1. Set up...

gregbrowndev

Previously the code would emit ```python DEFAULT_HOST: str = ``` Note that there is nothing at the end of the line. Now it emits ```python DEFAULT_HOST: str = '' ```...

achew22

allow `optional` proto fields that are annotated as `REQUIRED`

1

Unit tests fail when a field is proto3-`optional` but has `(google.api.field_behavior)=REQUIRED`. In spite of the fact the names sound like they are referring to the same thing, they're not, in...

vchudnov-g

Code: ``` from google.cloud.aiplatform_v1 import Citation Citation.to_dict(Citation()) ``` ``` { "start_index": 0, "end_index": 0, "uri": "", "title": "", "license_": "" } ``` Notice how the dictionary uses `license_` instead of...

Ark-kun

All google-cloud-language samples that initialize an input Document class are missing the required field `type`. Example: https://cloud.google.com/python/docs/reference/language/latest/google.cloud.language_v2.services.language_service.LanguageServiceAsyncClient#google_cloud_language_v2_services_language_service_LanguageServiceAsyncClient_moderate_text Current: ```py # Initialize request argument(s) document = language_v2.Document() document.content = "content_value" ```...

kuhanaklobasa

The async generated unit tests emit warning `RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited` ``` tests/unit/gapic/showcase_v1beta1/test_messaging.py::test_search_blurbs_async_use_cached_wrapped_rpc /home/runner/work/gapic-generator-python/gapic-generator-python/.nox/showcase_unit-3-12/lib/python3.12/site-packages/google/api_core/operation_async.py:126: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited if self._operation.HasField("response"): ``` See build log [here](https://github.com/googleapis/gapic-generator-python/actions/runs/9601325853/job/26479642053?pr=2045) from...

parthea

See https://github.com/googleapis/googleapis/blob/8242241358c63e091f749fce4c18c466172d2127/google/cloud/retail/v2alpha/project.proto#L178-L179 where there is an asterisk character which is not surrounded by backticks or escaped. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /home/runner/work/google-cloud-python/google-cloud-python/packages/google-cloud-retail/google/cloud/retail_v2alpha/types/project.py:docstring of google.cloud.retail_v2alpha.types.project.AlertConfig:5:Inline emphasis...

parthea

See https://github.com/googleapis/googleapis/blob/9516e70a70d6f7e0cd000ddd370d73656da09b96/google/shopping/merchant/accounts/v1beta/emailpreferences.proto#L38-L41 where there is an asterisk character which is not surrounded by backticks or escaped. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /home/runner/work/google-cloud-python/google-cloud-python/packages/google-shopping-merchant-accounts/google/shopping/merchant_accounts_v1beta/services/email_preferences_service/async_client.py:docstring of google.shopping.merchant_accounts_v1beta.services.email_preferences_service.async_client.EmailPreferencesServiceAsyncClient.get_email_preferences:4:Inline emphasis...

parthea

See build log [here](https://github.com/googleapis/google-cloud-python/actions/runs/9368980363/job/25792321566?pr=12773) from PR https://github.com/googleapis/google-cloud-python/pull/12773 ``` _ ERROR collecting tests/unit/gapic/merchant_accounts_v1beta/test_terms_of_service_service.py _ tests/unit/gapic/merchant_accounts_v1beta/test_terms_of_service_service.py:45: in from google.shopping.merchant_accounts_v1beta.services.terms_of_service_service import ( google/shopping/merchant_accounts_v1beta/services/terms_of_service_service/__init__.py:16: in from .async_client import TermsOfServiceServiceAsyncClient google/shopping/merchant_accounts_v1beta/services/terms_of_service_service/async_client.py:39: in from google.shopping.merchant_accounts_v1beta import...

parthea

compute_v1_generated_forwarding_rules_insert_sync.py not running in async fashion

1

https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-compute/samples/generated_samples/compute_v1_generated_forwarding_rules_insert_sync.py the code snippet runs in couple seconds but exits without a confirmation that the operation ran successfully checked the response.status , status: RUNNING means that this code snippet is...

mallocash05