gapic-generator-python

gapic-generator-python copied to clipboard

There are warnings in the [build logs](https://github.com/googleapis/gapic-generator-python/actions/runs/6984468065/job/19007340405?pr=1873). We should treat warnings as errors so we know when new warnings appear and create tracking bugs to resolve the existing warnings. ```...

parthea

The following SphinxWarnings appears in the docs build for `google-cloud-kms` ``` Traceback (most recent call last): File "/usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-kms/.nox/docs/lib/python3.9/site-packages/sphinx/cmd/build.py", line 280, in build_main app.build(args.force_all, filenames) File "/usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-kms/.nox/docs/lib/python3.9/site-packages/sphinx/application.py", line 350, in build...

parthea

See https://github.com/googleapis/googleapis/blob/42231337d84e862d417b6d3fd6af50ba0fcf932c/google/cloud/networkmanagement/v1/connectivity_test.proto#L204-L206 where there is a list which is not formatted correctly. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-network-management/google/cloud/network_management_v1/types/connectivity_test.py:docstring of google.cloud.network_management_v1.types.connectivity_test.Endpoint:38:Block quote ends without a blank...

parthea

See https://github.com/googleapis/googleapis/blob/42231337d84e862d417b6d3fd6af50ba0fcf932c/google/cloud/clouddms/v1/conversionworkspace_resources.proto#L473-L475 where there is a list which is not formatted correctly. This caused the docs build to fail with ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-dms/google/cloud/clouddms_v1/types/conversionworkspace_resources.py:docstring of google.cloud.clouddms_v1.types.conversionworkspace_resources.MultiColumnDatatypeChange:82:Unexpected indentation. Warning, treated as error:...

parthea

See https://github.com/googleapis/googleapis/blob/a549ce6e7b62f6fcb808dfec151bef631c986cd5/google/cloud/securitycentermanagement/v1/security_center_management.proto#L784-L786 where there is a list which is not properly formatted This caused the docs build to fail with ``` Shinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/google-cloud-python/packages/google-cloud-securitycentermanagement/google/cloud/securitycentermanagement_v1/types/security_center_management.py:docstring of google.cloud.securitycentermanagement_v1.types.security_center_management.UpdateSecurityHealthAnalyticsCustomModuleRequest:32:Unexpected indentation. ``` Instead of ```...

parthea

See https://github.com/googleapis/googleapis/blob/492e772e24f4122600c0e106945075a8ff3f6255/google/shopping/merchant/reports/v1beta/reports.proto#L355-L361 where there is a table defined in proto comments. ``` // Free listings | Shopping Ads | Status // --------------|--------------|------------------------------ // Approved | Approved | ELIGIBLE // Approved...

parthea

The following change: ```python3 self._api_endpoint = self._client._api_endpoint ``` in [asyncClient](https://github.com/googleapis/gapic-generator-python/blob/478066385450ee01df3ef9fadd68a14f5cc085ef/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/async_client.py.j2#L194) by this [PR](https://github.com/googleapis/gapic-generator-python/pull/1873) is added to not break the unit tests. This can be removed once `api endpoint` is added...

ohmayr

The method [`get_mtls_endpoint_and_cert_source`](https://github.com/googleapis/gapic-generator-python/blob/29af25de98ebf590214abfd6c4b40c7502bd2d11/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L220) is no longer used in the client i.e. see the following: https://github.com/googleapis/gapic-generator-python/pull/1873 This method can be deprecated after the PR https://github.com/googleapis/gapic-generator-python/pull/1868 is merged i.e. users can alternatively...

ohmayr

https://github.com/googleapis/gapic-generator-python/blob/043ce05a7493ab2892b3e2c72c2b715e81e5b0d9/gapic/templates/setup.py.j2#L22-L25 `version_candidates` is 0 when the release version is a release candidate. For example, `0.35.0rc1` instead of `0.35.0` will fail at installation time

parthea

files getting excluded when regenerating index.rst

2

There are three kinds of erroneous exclusions from `index.rst` we noticed when reviewing https://github.com/googleapis/google-cloud-python/pull/11635. The changes I had to manually make to fix these exclusions are shown [here](https://github.com/googleapis/google-cloud-python/pull/11635/files/048a1c0340b1ad527ec5cd5afc011770ee92b694..0a08b5099ed0816ae2713f205aac7b6d4261fa32). We should...

vchudnov-g