gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

Deprecate return_immediately flag in subscriber client's pull() method

Open plamut opened this issue 4 years ago • 3 comments

Original issue: https://github.com/googleapis/python-pubsub/issues/350

It will be cleaner to make this change in the generator itself as opposed to fiddling with synth.py.

plamut avatar Mar 29 '21 15:03 plamut

The original issue is not very clear. Can you elaborate on what change is required and why?

software-dov avatar Mar 29 '21 16:03 software-dov

@software-dov The return_immediately argument should not be set to True ever, as that can cause users to have more trouble retrieving the messages even if they are available, they might get empty messages, etc.... it's a backend thing.

The flag has been deprecated by the backend, but not all client libraries issue a warning if a stubborn user sets it to True nevertheless.

(BTW, I'm working on this already)

plamut avatar Mar 29 '21 16:03 plamut

As per discussion, we will not modify the templates for now, but instead add the change through synth.py.

We can keep this open as a possible low priority feature request to address this in a more systematic way.

plamut avatar Mar 31 '21 09:03 plamut