gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

Client streaming methods should send routing headers

Open busunkim96 opened this issue 5 years ago • 5 comments

Clients streaming methods should send routing headers on the initial RPC that opens the stream. Field headers are currently ignored for these methods https://github.com/googleapis/gapic-generator-python/blob/eaa6f3622ccf3f51a73635d8190ae2a07f036d89/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L329-L341

As far as I know this isn't currently an issue for any libraries on the microgenerator.

busunkim96 avatar Jun 09 '20 22:06 busunkim96

any updates as we are out of slo

arithmetic1728 avatar Oct 13 '20 06:10 arithmetic1728

@busunkim96 , can you clarify why this isn't an issue for libraries using micro-generator?

is this a feature gap between micro-generator and the legacy (monolith) that we need to support i.e adding routing headers to the streaming requests? If not, we should mark this bug as feature request or mark with appropriate priority so we can fix it. Please advice. Thanks!

P.S: This issue triggered OO-SLO.

hkdevandla avatar Dec 16 '20 22:12 hkdevandla

@hkdevandla None of the currently published APIs have a streaming method that requires a routing header be sent.

I opened this after discussion #443 which added routing headers for all the http verbs. The current behavior may be correct, but I opened this to make sure this comment was followed up on:

I was under the impression that headers for streaming methods don't make a lot of sense because they're not tightly bound to http semantics. If that's not correct, then I think we would need to ask someone who knows better.

Originally posted by @software-dov in https://github.com/googleapis/gapic-generator-python/pull/443#discussion_r437745208

busunkim96 avatar Dec 16 '20 22:12 busunkim96

Thanks @busunkim96, making this as P3 in that case if it is not an issue but needs some follow up/investigation.

hkdevandla avatar Dec 21 '20 21:12 hkdevandla

We are dropping this to a feature request for the time being.

software-dov avatar Oct 12 '21 20:10 software-dov