gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

[async rest] Add support for async request / response interceptors for unsupported methods

Open ohmayr opened this issue 1 year ago • 0 comments

The macro shared_macros.create_interceptor_class which generates an interceptor class for async / sync rest transport currently guards generation of asynchronous interceptor class methods for the following type of api methods:

  • lro
  • extended_lro
  • paged_result_field

As we add support for the api methods mentioned above in the asynchronous rest transport class, we need to ensure that support is also added for interceptor class methods for the corresponding api methods. This can be achieved by updating and eventually removing the following condition within the macro:

% if (not is_async) or (is_async and not method.lro and not method.extended_lro and not method.paged_result_field) %}

The above condition / code change location can be looked up by searching for this issue url / number.

ohmayr avatar Sep 12 '24 05:09 ohmayr