gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

ensure we have test coverage for gRPC bidi streaming

Open vchudnov-g opened this issue 1 year ago • 0 comments

This comment thread highlights that some unknown time ago, code that was apparently meant to cover several cases including bi-directional streaming was moved into sections of macro files that were only generated {% if not method.client_streaming %}. This raises the possibility that the corresponding bidi code might have had its test coverage accidentally removed. We should check whether that is indeed the case (I suggest starting with git blame to see when the code made it into test_macros.j2 from where), and if so, fix it.

vchudnov-g avatar Aug 29 '24 19:08 vchudnov-g