gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

support customizing routing metadata

Open daniel-sanche opened this issue 1 year ago • 0 comments

The gapic generator automatically attaches routing metadata based on the protos, by appending the x-goog-request-params to whatever metadata the user passes in. But sometimes users may want to customize the x-goog-request-params field itself. In bigtable, we need to customize the field based on some values set in the veneer layer

To solve this, I propose we add a check to ensure we are only setting x-goog-request-params when it doesn't exist in the passed in metadata, to avoid adding a duplicate field. But let me know if you have other thoughts

Related bigtable bug: https://github.com/googleapis/python-bigtable/issues/1004

daniel-sanche avatar Jul 27 '24 00:07 daniel-sanche