gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

add universe-domain tests

Open vchudnov-g opened this issue 1 year ago • 0 comments

In #1898 I made a few suggestions for improving test coverage of the user-configured universe domain feature. In order to not delay that PR further, I am strongly leaning towards merging that as soon as the presubmits with the latest changes pass, and implementing the testing suggestions in a follow-up PR. The suggestions are:

To be clear: we should make the tests as small as they can be (e.g. preferring unit tests to integration tests), and we should check whether the suggestions above have been already covered in other tests elsewhere in the codebase than where I made the comments above (I suspect in some cases that may be the case).

vchudnov-g avatar Jan 22 '24 22:01 vchudnov-g