gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

Generated unit test for dataform fails with `Couldn't build proto file into descriptor pool!`

Open parthea opened this issue 2 years ago • 2 comments

The generated unit tests for google/cloud/dataform/v1alpha2 fail with google.cloud.dataform.v1alpha2.CompilationResult.CodeCompilationConfig.vars_: map_entry should not be set explicitly. Use map<KeyType, ValueType> instead.

============================================================================== ERRORS ===============================================================================
_______________________________________________ ERROR collecting tests/unit/gapic/dataform_v1alpha2/test_dataform.py ________________________________________________
tests/unit/gapic/dataform_v1alpha2/test_dataform.py:40: in <module>
    from google.cloud.dataform_v1alpha2.services.dataform import DataformAsyncClient
google/cloud/dataform_v1alpha2/__init__.py:17: in <module>
    from .services.dataform import DataformClient
google/cloud/dataform_v1alpha2/services/dataform/__init__.py:16: in <module>
    from .client import DataformClient
google/cloud/dataform_v1alpha2/services/dataform/client.py:37: in <module>
    from google.cloud.dataform_v1alpha2.services.dataform import pagers
google/cloud/dataform_v1alpha2/services/dataform/pagers.py:27: in <module>
    from google.cloud.dataform_v1alpha2.types import dataform
google/cloud/dataform_v1alpha2/types/__init__.py:16: in <module>
    from .dataform import (
google/cloud/dataform_v1alpha2/types/dataform.py:2250: in <module>
    class QueryWorkflowInvocationActionsResponse(proto.Message):
.nox/unit-3-9/lib/python3.9/site-packages/proto/message.py:271: in __new__
    file_info.generate_file_pb(new_class=cls, fallback_salt=full_name)
.nox/unit-3-9/lib/python3.9/site-packages/proto/_file_info.py:104: in generate_file_pb
    pool.Add(self.descriptor)
E   TypeError: Couldn't build proto file into descriptor pool!
E   Invalid proto descriptor for file "google/cloud/dataform_v1alpha2/types/dataform.proto":
E     google.cloud.dataform.v1alpha2.CompilationResult.CodeCompilationConfig.vars_: map_entry should not be set explicitly. Use map<KeyType, ValueType> instead.

parthea avatar Jul 05 '22 11:07 parthea

Changing to p2 as there is a workaround. Renaming vars_ to vars solves the issue. It appears that vars_ is a reserved word in protobuf.

parthea avatar Jul 05 '22 14:07 parthea

There are currently two APIs affected by this issue:

//google/cloud/dataform/v1alpha2/dataform_py_gapic_test
//google/cloud/networkservices/v1/networkservices_py_gapic_test

vam-google avatar Jul 26 '22 20:07 vam-google