gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard

mypy test fails with gapic-generator-python 0.65.2

Open parthea opened this issue 3 years ago • 1 comments

The following code is failing the mypy test in https://github.com/googleapis/python-datastore/pull/306

        metadata = tuple(metadata) + (
            gapic_v1.routing_header.to_grpc_metadata((("project_id", ""),)),
        )

The error is

nox > mypy google/ tests/
tests/unit/gapic/datastore_admin_v1/test_datastore_admin.py:1817: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[]")

See build log here.

@atulep Please could you take a look?

parthea avatar Apr 28 '22 11:04 parthea

@parthea Can you please revisit your https://github.com/googleapis/gapic-generator-python/pull/1314 PR and merge it if possible? This issue isnow showing as out of SLO for us. Thanks!

vam-google avatar Aug 26 '22 22:08 vam-google

Closing as obsolete.

parthea avatar Feb 16 '23 18:02 parthea