gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard
verified publisher icon googleapis

gapic: Change to Set vs FrozenSet and thread the same set through

Open tmc opened this issue 4 years ago • 5 comments

This improves the performance dramatically for large type hierarchies.

Addresses #950

tmc avatar Jan 08 '22 02:01 tmc

Thanks so much for making these changes! Performance on big, complex APIs has been a pain point for a while. What APIs have you tested on? Do you have any before and after benchmark data? I'm a little bit concerned about changing frozenset to set because of the risk of mutating the caller's parameters. If you can show that the performance gained from that is substantial it would put my mind at ease.

software-dov avatar Jan 10 '22 16:01 software-dov

@tmc PTAL

vam-google avatar Jan 19 '22 23:01 vam-google

@vam-google any example that references the protobuf types from https://github.com/google/fhir will not effectively finish without a change such as this one.

tmc avatar Apr 04 '22 06:04 tmc

@tmc Please could you address the review comment and feedback from software-dov?

parthea avatar Apr 09 '22 23:04 parthea

@atulep @parthea PTAL.

tmc avatar Aug 26 '22 00:08 tmc

Converting to draft as presubmits are failing

parthea avatar Sep 02 '23 10:09 parthea

@parthea PTAL

tmc avatar Sep 02 '23 21:09 tmc