gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

chore(format): update google-java-format to 1.25.2 via java-shared-config update

Open diegomarquezp opened this issue 9 months ago • 2 comments

NOTE: Do not review this. There are too many files and I'm confirming the setup works and will then temporarily revert the format changes for reviewers to only show the CI and pom.xml related changes only.

This replaces https://github.com/googleapis/sdk-platform-java/pull/3724 in order to manually prepare the repo for this update. The preparation includes:

  • Update google-cloud-shared-config to 1.15.1.
  • Configure pom.xml files to reference the fmt plugin using the com.spotify.fmt groupId instead of com.coveo. The group ID in since 2022. Some pom.xml explicitly referenced the 2.9.1 version, but I removed it so it's controlled by google-cloud-shared-config.
  • Update our ci.yaml to either run the mvn tasks using java 17 or running the task with the -Dfmt.skip flag.
  • Update java_compatibility_check.yaml from java 11 to java 17.
  • Update our docker image to use java 17 instead of 11.
  • Format the codebase using mvn fmt:format.

diegomarquezp avatar Mar 28 '25 19:03 diegomarquezp

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
3.0% Coverage on New Code (required ≥ 80%)
30.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Apr 02 '25 18:04 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
61.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Apr 02 '25 18:04 sonarqubecloud[bot]