gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard
verified publisher icon googleapis

`update_generation_config.yaml` is not updated in downstream repos

Open diegomarquezp opened this issue 10 months ago • 1 comments

Downstream repos don't update this file. For example:

  • https://github.com/googleapis/java-datastore/commits/main/.github/workflows/update_generation_config.yaml
  • https://github.com/googleapis/java-bigtable/commits/main/.github/workflows/update_generation_config.yaml
  • https://github.com/googleapis/java-firestore/commits/main/.github/workflows/update_generation_config.yaml
  • https://github.com/googleapis/google-cloud-java/commits/main/.github/workflows/update_generation_config.yaml

This may extend to other files in the .github folder

diegomarquezp avatar Mar 13 '25 21:03 diegomarquezp

cc: @JoeWang1127 @suztomo I noticed that https://github.com/googleapis/sdk-platform-java/blob/main/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/build.sh is very different from https://github.com/googleapis/java-logging/blob/main/.kokoro/build.sh. Same story with java-bigtable. The different JOB_TYPE handling is not present in this template.

Java-logging still expects build.sh to be updated automatically.

diegomarquezp avatar Mar 21 '25 17:03 diegomarquezp

Fixed in https://github.com/googleapis/sdk-platform-java/pull/3723

diegomarquezp avatar May 01 '25 18:05 diegomarquezp