gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

Remove internet request in unit tests

Open JoeWang1127 opened this issue 1 year ago • 0 comments

The unit tests in hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py have real git clone and git checkout. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.

We should mock these operations to make the unit tests quick and deterministic.

JoeWang1127 avatar Nov 07 '24 19:11 JoeWang1127