gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

HeaderProvider reference is lost during ServiceOptions.toBuilder

Open burkedavison opened this issue 1 year ago • 2 comments

serviceOptions.toBuilder().build() should not cause field values to be unset.

burkedavison avatar May 24 '24 20:05 burkedavison

Thanks Burke! How did you notice this issue?

blakeli0 avatar May 24 '24 21:05 blakeli0

Working through specific requirements for https://github.com/GoogleCloudPlatform/spring-cloud-gcp/issues/2906 by creating a test for it. I found I couldn't modify LoggingOptions via toBuilder without erasing its header provider. https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/d8d7168e57683adf76b1e56b1a3e7d87fb7d8bdf/spring-cloud-gcp-logging/src/main/java/com/google/cloud/spring/logging/LoggingAppender.java#L43

burkedavison avatar May 28 '24 13:05 burkedavison