gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

Update hermetic build to use same proto files in BUILD.bazel in library generation

Open alicejli opened this issue 1 year ago • 0 comments

https://github.com/googleapis/google-cloud-java/pull/10802 is a new library generation request for visionai.v1. However, it failed due to prediction.proto being an empty service (e.g. no RPCs). Related issue on fixing the generator to skip generation for empty services: https://github.com/googleapis/sdk-platform-java/issues/2750

It's excluded in the visionai.v1 BUILD file: https://github.com/googleapis/googleapis/blob/master/google/cloud/visionai/v1/BUILD.bazel#L23-L36

To fix this for the long-term, we should consider either parsing BUILD.bazel to get the list of protos or consider integrating hermetic build scripts into Bazel so that the library generation will always use the same list of protos as the BUILD.bazel file.

alicejli avatar May 09 '24 17:05 alicejli