gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

feat: throw exception when user attempt to override api-version header.

Open zhumin8 opened this issue 1 year ago • 2 comments

As discussed offline, amend behavior so that if user code attempt to override api-version header via user header, conflict resolution in ClientContext would throw exception. This is consistent whether service itself sets api-version in proto or not (or empty).

TODO: when #2737 gets in, add a test case to ITApiVersionHeaders.java where attempts setHeaderProvider() and exception throws.

zhumin8 avatar May 07 '24 04:05 zhumin8

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 07 '24 06:05 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 07 '24 06:05 sonarqubecloud[bot]