gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

Make library generation unit tests a required check

Open JoeWang1127 opened this issue 1 year ago • 1 comments

The library-generation-unit-tests sprouts two jobs: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04).

The behavior of this check when setting library-generation-unit-tests (the parent job) as required:

  • On pull request that doesn't change library_generation directory: checks initiate and return result.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.

The behavior of this check when setting two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: checks initiate and return result.

The behavior of this check when setting parent and two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.

JoeWang1127 avatar May 05 '24 17:05 JoeWang1127

A potential solution: remove unit tests on macos since it adds little value.

JoeWang1127 avatar May 05 '24 17:05 JoeWang1127

Required checks that only run on certain path changes are discussed in https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks. I don't see we use the workaround.

suztomo avatar Aug 28 '24 23:08 suztomo