gapic-generator-java
gapic-generator-java copied to clipboard
chore: add generation config
java-iam/README.md is excluded from templating, should we not generate it?
I don't think it makes sense for both java-iam and java-common-protos to have READMEs, I think we can remove them and exclude them from generation. WDYT @suztomo ?
README.md files help people (including us) to understand the modules, regardless of it's generated or manually maintained.
README.md files help people (including us) to understand the modules, regardless of it's generated or manually maintained.
I'll exclude README.md
from generation and keep them as-is.
Owlbot postprocessor failed:
Status: Downloaded newer image for gcr.io/cloud-devrel-public-resources/owlbot-java@sha256:a57d2ea6d1a77aa96c17ad0850b779ec6295f88b6c1da3d214b2095d140a2066
gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a57d2ea6d1a77aa96c17ad0850b779ec6295f88b6c1da3d214b2095d140a2066
ls: cannot access '*/.OwlBot.yaml': No such file or directory
Processing a split repo
Generating templates and retrieving files from owl-bot-staging directory...
...done
Generating missing pom.xml...
/owlbot
working directory: /workspace/sdk-platform-java
Traceback (most recent call last):
File "/owlbot/src/fix-poms.py", line 504, in <module>
main()
File "/owlbot/src/fix-poms.py", line 279, in main
with open(".repo-metadata.json", "r") as fp:
FileNotFoundError: [Errno 2] No such file or directory: '.repo-metadata.json'
```
README.md files help people (including us) to understand the modules, regardless of it's generated or manually maintained.
I don't disagree with the usefulness of READMEs, but if you look at the content of the README of java-common-protos, and README of java-iam, they are awfully wrong. For java-common-protos, I think it was a mistake to generate README in the first place as it is not a service. For java-iam, I can see some value if it is properly maintained. But currently it is not maintained and provide incorrect information like still support Java 7.
Split this PR to 3 and merge them after release:
- script change in library generation
- remove
.OwlBot.lock.yaml
- generation config, copyright year and
.OwlBot.yaml
Quality Gate passed for 'gapic-generator-java-root'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Quality Gate passed for 'java_showcase_integration_tests'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Quality Gate passed for 'gapic-generator-java-root'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Quality Gate passed for 'java_showcase_integration_tests'
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication