gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

fix: Use ServiceName + MethodName as the regex for Otel

Open lqiu96 opened this issue 1 year ago • 4 comments

Fixes: https://github.com/googleapis/sdk-platform-java/issues/2502

Use a consistent Regex matching pattern for both gRPC and HttpJson. Copy the pattern used for gRPC into HttpJson.

Looking at the Method Descriptor for HttpJson (Compute as an example), the full method name does not match service.resource.action: https://github.com/googleapis/google-cloud-java/blob/1f9e63224424327a08e3663985773546b3f7808b/java-compute/google-cloud-compute/src/main/java/com/google/cloud/compute/v1/stub/HttpJsonBackendServicesStub.java#L85

It seems to match ServiceName/MethodName.

lqiu96 avatar Mar 07 '24 18:03 lqiu96

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 07 '24 18:03 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 07 '24 19:03 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 03 '24 17:05 sonarqubecloud[bot]

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 03 '24 17:05 sonarqubecloud[bot]