gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard

showcase samples should be part of golden tests

Open zhumin8 opened this issue 1 year ago • 4 comments

sample snippets here should be part of the golden testing for Showcase.

Steps to identify this:

rm -rf showcase/gapic-showcase/samples/
mvn clean install -DskipTests
cd showcase

then mvn compile -P update, expect the samples should be re-generated and added back. But this samples folder is not re-generated

zhumin8 avatar Feb 13 '24 16:02 zhumin8

I think it worked before, could it be an issue caused by migrating Showcase to the hermetic build scrips? cc: @diegomarquezp @JoeWang1127

blakeli0 avatar Mar 04 '24 16:03 blakeli0

Probably because we didn't copy sample directory in https://github.com/googleapis/sdk-platform-java/blob/main/showcase/scripts/generate_components.sh

JoeWang1127 avatar Mar 04 '24 16:03 JoeWang1127

Keeping this a P2 issue. Seems to be due to a regression in the hermetic build scripts.

lqiu96 avatar May 21 '24 16:05 lqiu96

This was done in the early phase of hermetic build when we didn't have the image. We should migrate the showcase module to use hermetic build image now, with a dedicated generation_config.yaml.

blakeli0 avatar Aug 06 '24 17:08 blakeli0