gapic-generator-java icon indicating copy to clipboard operation
gapic-generator-java copied to clipboard
verified publisher icon googleapis

generator: Consider removing @BetaApi from clients' secondary transport surface

Open burkedavison opened this issue 2 years ago • 0 comments

Current logic assumes only the first transport is GA and all other transports are BetaApi.

  1. Client stub settings default ChannelProvider builder getters

    • Example: https://github.com/googleapis/google-cloud-java/blob/main/java-iot/google-cloud-iot/src/main/java/com/google/cloud/iot/v1/stub/DeviceManagerStubSettings.java#L443-L448
    • Generation logic: https://github.com/googleapis/sdk-platform-java/blob/decd7f60017d45288e6c12493fa21e06f9c5f77c/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java#L288

  2. Client settings default ChannelProvider builder getters

    • Example: https://github.com/googleapis/google-cloud-java/blob/main/java-iot/google-cloud-iot/src/main/java/com/google/cloud/iot/v1/DeviceManagerSettings.java#L223-L228
    • Generation logic: https://github.com/googleapis/sdk-platform-java/blob/decd7f60017d45288e6c12493fa21e06f9c5f77c/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceSettingsClassComposer.java#L402

  3. LRO client getters

    • Example: Unknown
    • Generation logic: https://github.com/googleapis/sdk-platform-java/blob/decd7f60017d45288e6c12493fa21e06f9c5f77c/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceClientClassComposer.java#L527

burkedavison avatar Oct 11 '23 19:10 burkedavison