gapic-generator-go icon indicating copy to clipboard operation
gapic-generator-go copied to clipboard

Generator adds iterator.Done check where iterator is not defined in gapic-showcase

Open aandreassa opened this issue 5 months ago • 0 comments

The go_cli plugin is incorrectly adding a code block to check for iterator.Done in the generated file cmd/gapic-showcase/search-blurbs.go. This causes a compilation error because the iterator variable is not defined in that context. This is only an issue for that specific file.

PR reproducing the issue: https://github.com/googleapis/gapic-showcase/pull/1597

Steps to reproduce

  1. Updated dependencies as shown in https://github.com/googleapis/gapic-showcase/pull/1597
  2. Followed steps in for regenerating
  3. Code doesn't compile due to iterator variable.

aandreassa avatar Oct 21 '25 21:10 aandreassa