gapic-generator-go icon indicating copy to clipboard operation
gapic-generator-go copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

Format code with goimport prior to putting it in assembly target

Open codyoss opened this issue 2 years ago • 1 comments

We have a handful of diffs at the proto and gapic layer that are produced by running goimports on the code. It would be nice if we could run the tool in a starlark rule so that when code is copied by owlbot it is a much cleaner diff

https://github.com/googleapis/google-cloud-go/pull/7538/commits/34b55fcaa09ddd894b5ff27621d868e9cf4abe5f#diff-01bc0255a405f400a4b06195ac0925d1d62bd0e99f98dee773c1541ed1a8d725L25

codyoss avatar Mar 13 '23 18:03 codyoss

We could also consider using go/format for gapic level code to reduce diffs in files like doc.go in the example above

codyoss avatar Mar 13 '23 18:03 codyoss