elixir-google-api icon indicating copy to clipboard operation
elixir-google-api copied to clipboard

fix: Fix function spec for `Response.decode/2`

Open bernardd opened this issue 1 year ago • 1 comments

The input type for GoogleApi.Gax.Response.decode/2 was missing the error case (which is explicitly handled in the first function clause). The return type incorrectly specifies that the error type must be a Tesla.Env.t() when in fact it may return any type (for example :timeout is returned when the Mint HTTP client times out).

bernardd avatar Dec 18 '24 03:12 bernardd

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 18 '24 03:12 google-cla[bot]