Support pg v8

[seeARMS]

Trace doesn't work with the newest pg major release (v8). It would be great to add support for this, as currently the lib only works with versions 6-7.

[rueian]

It seems that the current logic of pg v7 plugin can be used with v8 directly.

[kintel]

TODO:

• [ ] Add v8 support
• [ ] Make sure v8 is tested
• [ ] Evaluate how well pg in general and pg v8 is supported in OpenTelemetry, and open tickets where appropriate

[danvk]

Here's a hack to enable the v7 pg plugin on pg v8. Use at your own peril.

for (const patch of require('@google-cloud/trace-agent/build/src/plugins/plugin-pg')) {
  if (patch.versions === '^7.x') {
    patch.versions = '^7.x || ^8.x';
  }
}

[weyert]

How can we progress this pull request?

[yocontra]

Looking at the actual changelog the only reason it went from v7 to v8 is because node 6 support was dropped: https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md#pg800

It should be really quick to just add 8.x to the versions list. I would send a PR but I'm having a hard time wrapping my head around how the testing and build process works for this project, especially with the typings setup (Where do these files come from? https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/types/index.d.ts#L34)

Will look again later today using https://github.com/googleapis/cloud-trace-nodejs/commit/f070636eb4ed9adb3f59c55e354913915f495f1e as a template

[bcoe]

@contra thanks for taking a look, I'll bring this issue up internally as well, see if I can get anyone's 👀 on it.

[Zorato]

Hey @bcoe any good news on this?

[bcoe]

@Zorato unfortunately no updates, @kintel do you know who a good person to loop in would be?

[kintel]

@jarek-dudek @gkf Could you follow up on this?

[gkf]

Sorry I don't have much to add. This is effectively on our backlog currently.

[punya]

We don't expect to be able to add pg v8 support to the Cloud Trace NodeJS agent any time soon.

Please consider using OpenTelemetry instead -- @opentelemetry/instrumentation-pg supports pg v8.x.

[yasha-spare]

@punya does this mean cloud-trace-nodejs is deprecated, and people should generally be switching to a different approach, like OpenTelemetry, for sending traces to Google Cloud Trace from node backends?

[punya]

Hi @yasha-spare, thanks for the question - it's a reasonable one.

Cloud-trace-nodejs will continue to fix bugs and add security patches. We will consider merging new feature contributions (depending on the anticipated maintenance cost). But we won't develop new features ourselves.

To your larger question: yes, we recommend that new codebases start out with OTel. Existing users of cloud-trace-nodejs need to make a more nuanced decision about when their library dependencies will no longer be supported by cloud-trace-nodejs.

We intend to add documentation (a migration guide) to help with this process.

[yasha-spare]

Cool, thanks for the swift reply/clarification @punya !