api-linter icon indicating copy to clipboard operation
api-linter copied to clipboard

fix(AIP-158): fix too-broad isPaginatedResponseMessage filter function

Open wilesproof opened this issue 2 years ago • 3 comments

isPaginatedResponseMessage currently catches ALL messages with a field named next_page_token. After some discussion, we figured that should change to messages starting with List or Search and ending with Response, or fields ending with Response and containing a next_page_token field, to prevent next_page_tokens from being used in contexts outside of list/search.

wilesproof avatar Jul 01 '22 21:07 wilesproof

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 01 '22 21:07 google-cla[bot]

Please change your commit message to be fix(AIP-158): fix filter function or something in that format fix(AIP-158): message

noahdietz avatar Jul 01 '22 21:07 noahdietz

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

+1 fix/add tests

shwoodard avatar Jan 11 '23 17:01 shwoodard

Closing as inactive. Please reopen and address comments if this is still something worth considering.

noahdietz avatar Jul 31 '23 22:07 noahdietz