api-linter icon indicating copy to clipboard operation
api-linter copied to clipboard

Rule catches any message with "next_page_token" field OR named [List|Search]*Response

Open wilesproof opened this issue 2 years ago • 0 comments

https://github.com/googleapis/api-linter/blob/2aa02dc7978a18afd0eb72aa640c3cd90c932c61/rules/aip0158/aip0158.go#L56 seems wrong- according to https://linter.aip.dev/158/response-plural-first-field it should not fire for anything not named [List|Search]*Response, so that || should be an &&.

As it's currently implemented, it puts a global lock on naming any proto field "next_page_token" and using api-linter, which is problematic.

wilesproof avatar Jun 30 '22 21:06 wilesproof