api-linter icon indicating copy to clipboard operation
api-linter copied to clipboard

`limit` field should not raise a linter error

Open jmwski opened this issue 3 years ago • 0 comments

Environment details

  • Programming language: proto3
  • OS: N/A
  • Language runtime version: N/A
  • Package version: N/A

I am internal g3 user CL.

Steps to reproduce

A linter warning is raised for the following field (the directive is required to silence this warning):

    // (-- api-linter: core::0140::prepositions=disabled
    // aip.dev/not-precedent: Consistent with an already public api. --)
    optional int32 limit = 3;

a) limit is both a noun and a verb, so makes sense on its own. b) we aren't using it as a preposition of another word, we really are describing a Limit. c) Limit isn't on the official list of forbidden words: https://linter.aip.dev/140/prepositions

jmwski avatar Apr 28 '22 14:04 jmwski