api-linter icon indicating copy to clipboard operation
api-linter copied to clipboard

"Enum unspecified value" rule inaccurate to AIP

Open mbleigh opened this issue 2 years ago • 0 comments

Steps to reproduce

  1. Write an enum with a meaningful zero value
  2. Enable strict API linter
  3. Linter flags missing _UNSPECIFIED value

The issue here is that the AIP itself has an exception for a "clearly useful zero value". This means that even in the strict API linter it should be possible to have an enum with a meaningful zero value because it's an exception to the rule, not just an ignored should.

mbleigh avatar Oct 17 '23 21:10 mbleigh