api-common-protos icon indicating copy to clipboard operation
api-common-protos copied to clipboard

Confusing instruction on using proto js package

Open jasonclg opened this issue 3 years ago • 0 comments

According to the note in https://github.com/googleapis/api-common-protos#packages

Note that if using these packages, you will still need a local copy of these protos when using protoc, but you will not need to ship compiled versions of them. (This is consistent with protoc's default behavior of only providing compiled output for the files specifically requested, and not their imports.)

This does not seem right for js package. I protoc compiled my proto file with those imports from google-proto-files. Apparently I have to ship compiled version of imported protos too because the google-proto-files does not contain them (unlike the packages for other languages or imports from google/protobuf/).

jasonclg avatar Nov 22 '22 22:11 jasonclg