videojs-ima icon indicating copy to clipboard operation
videojs-ima copied to clipboard

Fix Compatibility Issue by Using video.js 7.x with videojs-ima and videojs-contrib-ads

Open ale-grosselle opened this issue 1 year ago • 3 comments

In our project, we decided to upgrade video.js to version 8.x to take advantage of the latest features and improvements. However, during the upgrade process, we encountered a module resolution error. The issue arises because we intend to use video.js 8.x, but the videojs-ima plugin depends on videojs-contrib-ads version 6.*, which in turn requires video.js version 7 (see here).

To resolve this issue, we will temporarily revert to video.js version 7.x, as it is compatible with the necessary dependencies. This solution will ensure the seamless integration of videojs-ima and videojs-contrib-ads in our project.

ale-grosselle avatar Jul 30 '24 13:07 ale-grosselle

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 30 '24 13:07 google-cla[bot]

@ale-grosselle You can utilise [email protected] exact version in case you want to use videojs8. Btw , I have also raised a PR for this but no response yet.

dds05 avatar Jun 16 '25 19:06 dds05

Hello @ale-grosselle ,

The videojs-contrib-ads dependency has been update in the latest version of the plugin (v2.4.0).

If you can confirm that this resolves your issue, please feel free to close this PR.

Thank you, Jackson IMA SDK team

Kiro705 avatar Jun 17 '25 14:06 Kiro705