googleads-python-lib icon indicating copy to clipboard operation
googleads-python-lib copied to clipboard

Published 20 hours ago • verified publisher icon googleads

Remove unused dependency: xmltodict

Open gdrosos opened this issue 1 year ago • 0 comments

Summary

Hello @christopherseeley, @msaniscalchi,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused dependency xmltodict from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The xmltodict package was added in e8dea47, and was used in googleads/adwords.py. However, this file was later removed, and upon analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

  • Removed the dependency to the xmltodict PyPI package from the `setup.py file.
  • Removed the corresponding dependnency requirement from the README.

Impact

  • Reduced package size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified dependency tree: Fewer dependencies make the project easier to maintain and can speed up installation.

I have also signed a individual CLA, according to CONTRIBUTING.md

gdrosos avatar Aug 27 '23 12:08 gdrosos