googleads-consent-sdk-ios icon indicating copy to clipboard operation
googleads-consent-sdk-ios copied to clipboard

Fix issue with parsing JSON response in incorrect CP1251 encoding

Open accidbright opened this issue 6 years ago • 4 comments

Issue: https://github.com/googleads/googleads-consent-sdk-ios/issues/13

accidbright avatar May 25 '18 09:05 accidbright

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar May 25 '18 09:05 googlebot

I signed it!

accidbright avatar May 25 '18 09:05 accidbright

CLAs look good, thanks!

googlebot avatar May 25 '18 09:05 googlebot

when will this be merged ? @googlebot why are there alot of issues you guys reviewed but have not merged ?

Izzyjm avatar Mar 25 '19 20:03 Izzyjm