google-api-ads-ruby icon indicating copy to clipboard operation
google-api-ads-ruby copied to clipboard

Published 20 hours ago • verified publisher icon googleads

Set nokogiri dependency to 1.6 for google-ads-common

Open mherasymiv-blackbird opened this issue 11 months ago • 2 comments

Upgrade fails because of dependency on nokogiri version (1.12.5)

Follow up from comment

We should not depend on such an old nokogiri version. Also it has to be consistent with version used in ads-savon.

mherasymiv-blackbird avatar Mar 05 '24 17:03 mherasymiv-blackbird

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 05 '24 17:03 google-cla[bot]