googleads
Support for proto-plus>=1.19.7
Describe the problem you are trying to solve: Use google-ads in conjunction with other python libraries.
Describe the solution you'd like: Being able to install google-ads latest version together with proto-plus >= 1.19.7 (as it is constraint for some other libraries, e.g. autogenerated google-cloud-datacatalog-lineage which has constraint proto-plus >= 1.19.7)
Additional context: In Cloud Composer we would like to install latest versions of other google libraries like google-cloud-firestore (https://github.com/googleads/google-ads-python/issues/659), google-cloud-datacatalog-lineage, etc., but this is not feasible as google-ads has dependency on old version of proto-plus, and ignoring pip conflicts is not feasible alternative.
It looks like the general concern about adding support for newer versions of proto-plus is that it has performance regression. Is it possible to do performance testing on the fresh versions of this package (https://pypi.org/project/proto-plus/#history) and decide if we can bump constraint to any other >=1.19.7 that doesn't have performance regression? https://github.com/googleads/google-ads-python/blob/9541a751a2c8d8bd7abf97b0d3a9f61e0ebbcb57/setup.py#L28
This is a severe issue right now for Cloud Composer to have google-ads incompatible with other python google libraries of latest versions.
@bobhancock @BenRKarl I would like to point your attention to this issue as it is severe enough for Cloud Composer team right now.
@kosteev thanks for pinging on this issue. We did a round of performance testing in around March that indicated that proto-plus versions newer than 1.19.6 were too slow for this library. We're going to go back and dig into those results, and run some more tests with the most recent versions to see what the trade-offs would be today. In the meantime, is it possible to use older versions of google-cloud-firestore and google-cloud-datacatalog-lineage that are compatible with proto-plus 1.19.6?
Hi all,
quick +1 because we're also facing incompatibility issues. In our case we cannot install google-cloud-pubsub>=2.13.6 because it requires proto-plus >= 1.22.0, <2.0.0dev:
https://github.com/googleapis/python-pubsub/blob/main/setup.py
Thanks @anneadb - we're working on a fix for this that I expect will be part of the next release.
hi @BenRKarl, is there an estimate time on the next release date? this is also a blocking for us
Hi all - we just released version 18.1.0, which bumps our dependency on proto-plus to version 1.22.0.
thanks a lot!
On Tue, Aug 23, 2022 at 08:10 Kosteev Eugene @.***> wrote:
Thank you very much!
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/googleads/google-ads-python/issues/662*issuecomment-1223980014__;Iw!!PYhZlW11KQ!GMvUoQF2UqUBReDVnmDA-WB-pv3CPWmEgCdYp6Pz1o9a5k4i9nO0S23mcnzd4-Jb3yNPXoNSWwXgXhuIaUCyDHva$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ADPI62IDQ575YQJNQWHAWTLV2S5TFANCNFSM52V3URGQ__;!!PYhZlW11KQ!GMvUoQF2UqUBReDVnmDA-WB-pv3CPWmEgCdYp6Pz1o9a5k4i9nO0S23mcnzd4-Jb3yNPXoNSWwXgXhuIaW5iJ0de$ . You are receiving this because you commented.Message ID: @.***>