zx icon indicating copy to clipboard operation
zx copied to clipboard

Add minute support in duration (#703)

Open RezaKargar opened this issue 1 year ago • 1 comments

This fixes #703

I also added test related to the change.

RezaKargar avatar Dec 02 '23 20:12 RezaKargar

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 02 '23 20:12 google-cla[bot]

Hey, @RezaKargar,

type Duration should be updated too.

antongolub avatar Mar 27 '24 13:03 antongolub

Thanks @antongolub, It's done.

RezaKargar avatar Mar 27 '24 16:03 RezaKargar

Seems good. Rebase plz.

antongolub avatar Mar 27 '24 18:03 antongolub

Dear @antongolub, I locally rebased the branch to solve conflicts.

RezaKargar avatar Mar 27 '24 19:03 RezaKargar

Hey @antonmedv, I fixed the prettier issue.

RezaKargar avatar Mar 28 '24 07:03 RezaKargar

Tests fixed too. @antonmedv

RezaKargar avatar Mar 28 '24 07:03 RezaKargar

Nice, thanks

perrinjerome avatar Mar 28 '24 11:03 perrinjerome