zx icon indicating copy to clipboard operation
zx copied to clipboard

add open package

Open pomdtr opened this issue 1 year ago • 1 comments

Fixes #491

  • [x] Tests pass
  • [x] Appropriate changes to README are included in PR
  • [x] Types updated

pomdtr avatar Aug 04 '22 11:08 pomdtr

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 04 '22 11:08 google-cla[bot]

Let's not add this to zx. Zx already really big. I'm thinking of adding something like

await npm('open').open(...)

antonmedv avatar Aug 21 '22 20:08 antonmedv

Let's not add this to zx. Zx already really big. I'm thinking of adding something like

await npm('open').open(...)

Interesting, it reminds me of the npm util from scriptkit: https://www.scriptkit.com/docs/npm-packages

pomdtr avatar Aug 21 '22 20:08 pomdtr

await npm('open').open(...)

So, if I understand correctly, it will be possible to use npm dependencies without having a package.json and node_modules?

If that's the case, it will be awesome!

webNeat avatar Aug 21 '22 21:08 webNeat

I found this library which tackle the "import at runtime" issue: https://www.npmjs.com/package/live-plugin-manager

pomdtr avatar Aug 21 '22 22:08 pomdtr

closed in favour of https://github.com/google/zx/pull/498

pomdtr avatar Aug 27 '22 15:08 pomdtr