yapf icon indicating copy to clipboard operation
yapf copied to clipboard

Commenting one parameter in function call makes yapf split all parameters

Open swigicat opened this issue 3 years ago • 1 comments

Using yapf 0.32.0

[style]
column_limit=30
split_before_first_argument = False

The following code

a(parameter,parameter,parameter,parameter,parameter,parameter)

produces

a(parameter, parameter,
  parameter, parameter,
  parameter, parameter)

However commenting one of the parameters

a(parameter,parameter,parameter,parameter,
    #parameter,
    parameter)

produces

a(
    parameter,
    parameter,
    parameter,
    parameter,
    #parameter,
    parameter)

Is this intended behavior?


Edit:

This also happens when one adds a comment to one of the parameters, i.e.

a(parameter,parameter,parameter,parameter,
    parameter, # a
    parameter)

produces

a(
    parameter,
    parameter,
    parameter,
    parameter,
    parameter, # a
    parameter)

swigicat avatar Mar 04 '22 15:03 swigicat

It may not be 100% intentional. Most likely it's due to a variety of different heuristics playing off of each other. Formatting function calls is extremely tricky, so there's a lot of hacking that went into doing so (and should be cleaned up).

bwendling avatar Mar 06 '22 01:03 bwendling