xpk icon indicating copy to clipboard operation
xpk copied to clipboard

Enable cluster and workload creation on A3+.

Open yangyuwei opened this issue 9 months ago • 1 comments

Fixes / Features

  • remove nccl plugin installation in workload creation on A3
  • enable cluster and workload creation on A3+

Testing / Documentation

Manual tests passed for cluster creation and workload creation on A3+.

  • [ y ] Tests pass
  • [ y ] Appropriate changes to documentation are included in the PR

yangyuwei avatar May 14 '24 18:05 yangyuwei

LGTM overall! Just some small requests

Thanks for the review! I've updated the code based on your comments in the latest commit (https://github.com/google/xpk/commit/091edf65ba29b6311c098665d911527b314ec60f). PTAL.

yangyuwei avatar May 16 '24 23:05 yangyuwei