xls icon indicating copy to clipboard operation
xls copied to clipboard
verified publisher icon google

dslx/stdlib: add iterative_div_mod

Open proppy opened this issue 2 years ago • 5 comments

  • add iterative_div_mod based on https://github.com/google/xls/blob/fa7af6cbda69d02d2d50b28fa5d95f51fe8cdfb1/xls/ir/abstract_evaluator.h#L513-L581
  • unify implementation with existing iterative_div function

proppy avatar Apr 14 '23 02:04 proppy

@meheff fyi

proppy avatar Apr 19 '23 16:04 proppy

PTAL, unified the DSLX stdlib division with the existing IR divmod implementation.

proppy avatar Jun 26 '23 09:06 proppy

Rebased.

proppy avatar Jun 26 '23 09:06 proppy

PTAL

proppy avatar Jun 27 '23 06:06 proppy

I think this need a rebase to merge, thanks.

cdleary avatar Mar 27 '24 03:03 cdleary

Nevermind previous comments, we can fix them up after landing this. (Just noticed how long this was sitting, and that I'd already approved it ages ago.)

ericastor avatar Apr 03 '24 12:04 ericastor